This post continues the series of articles, which can well be called “horrors for developers”. This time it will also touch upon a typical pattern of typos related to the usage of numbers 0, 1, 2. The language you’re writing in doesn’t really matter: it can be C, C++, C#, or Java. If you’re using constants 0, 1, 2 or variables’ names contain these numbers, most likely, Freddie will come to visit you at night. Go on, read and don’t say we didn’t warn you.
ReactOS
Avoid using a macro if you can use a simple function
The fragment is taken from ReactOS project. The code contains an error that analyzer diagnoses in the following way: V640 The code’s operational logic does not correspond with its formatting. The second statement will always be executed. It is possible that curly brackets are missing.
Table-style formatting
Fragment taken from the ReactOS project (open-source operating system compatible with Windows). The error is detected by the following diagnostic: V560 A part of conditional expression is always true: 10035L.