Copy-Paste

V581 The conditional expressions of the ‘if’ operators situated alongside each other are identical. Check lines: 2384, 2390. debug.c 2390

int dbg_check_nondata_nodes_order(....)
{
  ....
  sa = container_of(cur, struct ubifs_scan_node, list);
  sb = container_of(cur->next, struct ubifs_scan_node, list);

  if (sa->type != UBIFS_INO_NODE && 
      sa->type != UBIFS_DENT_NODE &&
      sa->type != UBIFS_XENT_NODE) {
    ubifs_err(c, "bad node type %d", sa->type);
    ubifs_dump_node(c, sa->node);
    return -EINVAL;
  }
  if (sa->type != UBIFS_INO_NODE &&   
      sa->type != UBIFS_DENT_NODE && 
      sa->type != UBIFS_XENT_NODE) { 
    ubifs_err(c, "bad node type %d", sb->type);
    ubifs_dump_node(c, sb->node);
    return -EINVAL;
  }
  ....
}

The analyzer complains about two similar conditions in a row: perhaps in the second condition the programmer forgot to change sa to sb.

Please click here to see more bugs from this project.